How to Prepare a Patch
http://xml.apache.org/http://www.apache.org/http://www.w3.org/

Main

How-Tos
Index

Using Cocoon
Paginator
HTML-PDF
Chaperon
Flow Debugger

Documentation
Author How-To
Author FAQ
Author Snippet
Author Docs

Contribution
Prepare patch
Bugzilla

Overview

A "Patch" is the set of differences between two versions of the same file. Patches are used to send someone the exact changes that you have made to your version of a program or a document. They can then apply that patch to their version to merge the changes and bring their version up-to-date with your version.

As our example we use the contribution of a simple documentation patch for the Apache Cocoon project. The principles apply to any project and to any type of file, e.g. *.xml, *.java, *.txt

Intended Audience

Anyone who wants to contribute to a project. This document addresses the basics, so as to get new people started.

Our example describes the use of command-line tools for a UNIX system. Other tools can be used, as long as they produce a "unified diff"

Prerequisites

Contributers should have:

  • The source code of the documents as a local working copy of the CVS repository. If you are working with the current CVS HEAD then you will have already done a 'cvs checkout cocoon-2.0' (see CVS Usage Precis). However, see below for other ways of obtaining source for diff comparison.
  • The tools with which to prepare a patch. On UNIX the "cvs" program has the 'cvs diff -u' command.
Steps

Here is how to proceed.

1. Understand what a patch is

A "Patch" is the set of differences between two versions of the same file. A patch comprises one or more "diff" files. These diffs are produced by the program of the same name: diff.

Here is an example of a single diff for the Cocoon Contribution page, where we are suggesting a minor text change. Do not get frightened. These are just human-readable instructions to the "patch" program.

Index: contrib.xml
===================================================================
RCS file: /home/cvspublic/cocoon-2.0/src/documentation/xdocs/contrib.xml,v
retrieving revision 1.7
diff -u -r1.7 contrib.xml
--- contrib.xml 30 Apr 2002 07:44:52 -0000      1.7
+++ contrib.xml 26 May 2002 04:08:23 -0000
@@ -208,7 +208,7 @@
    to create a patch. (The commands are for Linux.)
   </p>

- <s2 title="How to Establish your Local Repository">
+ <s2 title="How to Establish your Local Working Copy">

   <p>
    This will checkout the current copy of the master cvs repository and

That is a "unified diff" ... there a some lines of context on each side of the changes. This patch is basically saying "Change the text on line 208".

  • lines to be deleted are preceded with -
  • lines to be added are preceded with +
  • contextual lines with no leader remain the same
2. Modify your document and ensure consistency

Let us now go though the process of preparing that patch. Go ahead and edit your local copy of the document at $COCOON_HOME/src/documentation/xdocs/contrib.xml

Ensure that it is valid XML using your favourite XML editor or an external validating parser. Please do not leave it up to the poor committer to fix broken XML.

Run build docs to be sure that links are not broken and that the new document is presented as you intend it to be.

3. Get ready

If you are using the HEAD of CVS then ensure that your working copy is up-to-date. Of course, if you are using a previous public release version of Cocoon, then it is already up-to-date.

4. Generate the differences

Prepare the diff file. CVS will contact the remote repository, ensure that your working copy is up-to-date, then compare your local copy with the master repository.

cd src/documentation/xdocs
cvs diff -u contrib.xml > $WORK/cocoon/patch/contrib.xml.diff
5. Pack it up

With a patch that involves multiple separate diffs and/or new whole xml files, then please pack them into a compressed archive, e.g. my-patch.tar.gz or my-patch.zip

Also, if it helps to make your contribution clearer, then you might replicate the directory structure. Only bother with this for a complex patch.

+---$WORK/cocoon/patch
|   +---howto
|   |   +---book.xml.diff ........... differences to book.xml to link the 2 docs
|   |   +---howto-new-topic-a.xml ... a complete new document
|   |   +---howto-new-topic-b.xml ... a complete new document
|   +---link
|   |   +---livesites.xml.diff
|   |   +---books.xml.diff
|   |   
6. Describe the patch

Prepare a brief explanation of what your patch does. Get this ready in a text file before you go to Bugzilla. See further hints about this in the "Description" section of the How-to Bugzilla.

What version of CVS did you patch against? Was it HEAD branch? Was it a nightly build? Was it a public release?

7. Submit via Bugzilla

To contribute your patch to a specific project, use Bugzilla - The Apache Bug Database. The procedure is explained in How to Contribute a Patch via Bugzilla.

Real World Extension
Multiple diffs in a single patch

A patchfile can contain the differences to various individual documents. For example, the following command does that ...

cd src/documentation/xdocs
cvs diff -u contrib.xml userdocs/concepts/sitemap.xml > my-patch.diff

However, be careful not to go overboard with this technique. Often it is better to produce individual diffs and then pack them all into one .zip archive. When producing multiple diffs in one patchfile, try to limit it to one particular topic, i.e when fixing the same broken external link in various pages, then it would be fine to produce a single diff. Consider the committer - they will find it hard to apply your patch if it also attempts to fix other things.

Other ways of obtaining source for diff comparison

Ideally you will prepare your patches against a CVS repository. There are other ways to do this. They do create more work for the committers, however it may be the only way that you can do it. We would certainly rather receive your patch however it comes.

You could get the source document via the web interface to CVS. Here are the steps ...

  • get the relevant XML file via ViewCVS
  • save the file to your local disk: ./contrib.xml.orig
  • create a copy of the file: ./contrib.xml
  • make your modifications and validate the XML
  • use the "diff" command (i.e. not 'cvs diff') as follows
    diff -u contrib.xml.orig contrib.xml > patch/contrib.xml.diff
  • proceed as for Step 5.

There is another method if all else fails. You could save the public HTML page that was generated by Cocoon (currently static) and then prepare your diffs against the HTML source. This is obviously much harder for the committer, and should only ever be used for minor text edits. Here are the steps ...

  • save the relevant web page (contrib.html) to your local disk: ./contrib.html.orig
  • create a copy of the file: ./contrib.html
  • make your modifications and view the page with your browser
  • use the "diff" command (i.e. not 'cvs diff') as follows
    diff -u contrib.html.orig contrib.html > patch/contrib.html.diff
  • proceed as for Step 5.
Tips
  • Please review your diffs before you submit your patch to Bugzilla
References
  • The UNIX manual pages 'man diff' and 'man patch'.
  • CVS usage information is at www.cvshome.org and your local 'info cvs' pages or 'man cvs' pages or user documentation. This includes guidance about using cvs diff -u
Copyright © 1999-2002 The Apache Software Foundation. All Rights Reserved.